feat: add shadow DOM support for element identification #56
+2,532
−410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getParentElement() helper to traverse across shadow boundaries - Add closestCrossingShadow() to replace Element.closest() for shadow DOM - Add isInShadowDOM() and getShadowHost() utility functions - Add getShadowAwareSelectors() for generating queryable paths - Update getElementPath() to mark shadow boundary crossings with ⟨shadow⟩ - Update getFullElementPath() for shadow DOM traversal - Update getNearbyElements() to work inside shadow roots - Update identifyElement() to use shadow-aware traversal for SVG elements - Export new shadow DOM utilities from index.ts
|
@redsquare is attempting to deploy a commit to the Benji Taylor's Projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive shadow DOM support to the element identification utilities, enabling Agentation to work correctly with web components and shadow DOM elements.
Changes
New Utility Functions
getParentElement(element)- Gets parent element, crossing shadow DOM boundariesclosestCrossingShadow(element, selector)- Likeclosest()but crosses shadow boundariesisInShadowDOM(element)- Checks if an element is inside a shadow rootgetShadowHost(element)- Gets the shadow host for an element in shadow DOMgetShadowAwareSelectors(element)- Generates selectors for shadow DOM elementsUpdated Functions
getElementPath()- Now marks shadow boundaries with⟨shadow⟩marker and traverses into light DOMgetFullElementPath()- Updated to traverse shadow boundaries correctlygetNearbyElements()- Updated to use shadow-aware parent traversalidentifyElement()- Returns contextual identification including shadow DOM infoTest Page
Added
/shadow-dom-testpage in the example app that verifies:isInShadowDOM()detectiongetShadowHost()retrievalidentifyElement()for shadow DOM elementsgetShadowAwareSelectors()outputTesting
cd _package-export/example && pnpm run dev/shadow-dom-test⟨shadow⟩markerUse Case
This enables Agentation to work correctly with: